Skip to content

Add test for derive helper compat collisions #149200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 25, 2025
Merged

Add test for derive helper compat collisions #149200

merged 2 commits into from
Nov 25, 2025

Conversation

@yaahc
Copy link
Member

@yaahc yaahc commented Nov 21, 2025

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 21, 2025
petrochenkov
petrochenkov reviewed Nov 24, 2025
View reviewed changes
@petrochenkov
Copy link
Contributor

petrochenkov commented Nov 24, 2025

r=me with the comments addressed.
@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 24, 2025
yaahc and others added 2 commits November 24, 2025 10:52
@yaahc yaahc force-pushed the helper-compat-test branch from a588697 to 7537b0b Compare November 24, 2025 18:52
@yaahc
Copy link
Member Author

yaahc commented Nov 24, 2025

@bors r=petrochenkov

@bors
Copy link
Collaborator

bors commented Nov 24, 2025

📌 Commit 7537b0b has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 24, 2025
@yaahc yaahc mentioned this pull request Nov 24, 2025
Open
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 24, 2025
@matthiaskrgr
Rollup merge of rust-lang#149200 - yaahc:helper-compat-test, r=petroc…
bfbaac7 
…henkov

Add test for derive helper compat collisions

Resolves rust-lang/reference#2055 (comment)

r? `@petrochenkov`
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 24, 2025
Closed
bors added a commit that referenced this pull request Nov 24, 2025
@bors
Auto merge of #149290 - matthiaskrgr:rollup-74v8k3e, r=matthiaskrgr
2f42bdc 
Rollup of 3 pull requests

Successful merges:

 - #148652 (Cleanup and refactor FnCtxt::report_no_match_method_error)
 - #149200 (Add test for derive helper compat collisions)
 - #149274 (Fix invalid link generation for type alias methods)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors
Copy link
Collaborator

bors commented Nov 25, 2025

⌛ Testing commit 7537b0b with merge cdb4236...

@bors
Copy link
Collaborator

bors commented Nov 25, 2025

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing cdb4236 to main...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 25, 2025
@bors bors merged commit cdb4236 into rust-lang:main Nov 25, 2025
12 checks passed
@rustbot rustbot added this to the 1.93.0 milestone Nov 25, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 25, 2025

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing c871d09 (parent) -> cdb4236 (this PR)

Test differences

Show 4 test diffs

Stage 1

  • [ui] tests/ui/proc-macro/helper-attr-compat-collision.rs: [missing] -> pass (J0)

Stage 2

  • [ui] tests/ui/proc-macro/helper-attr-compat-collision.rs: [missing] -> pass (J1)

Additionally, 2 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard cdb4236e654a49c3035269588fe22dfafc0cfa3a --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. tidy: 196.7s -> 142.8s (-27.4%)
  2. aarch64-apple: 10090.8s -> 8352.9s (-17.2%)
  3. x86_64-gnu-llvm-20: 2420.0s -> 2782.2s (+15.0%)
  4. test-various: 6070.1s -> 6851.7s (+12.9%)
  5. pr-check-1: 1735.1s -> 1935.7s (+11.6%)
  6. i686-gnu-2: 5602.9s -> 6192.7s (+10.5%)
  7. pr-check-2: 2321.1s -> 2559.5s (+10.3%)
  8. x86_64-gnu-llvm-21-2: 5171.4s -> 5588.5s (+8.1%)
  9. dist-powerpc-linux: 4943.8s -> 5334.1s (+7.9%)
  10. dist-aarch64-msvc: 5468.0s -> 5894.1s (+7.8%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

rust-timer commented Nov 25, 2025

Finished benchmarking commit (cdb4236): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (secondary 5.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 5.6% [5.6%, 5.6%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 469.468s -> 471.494s (0.43%)
Artifact size: 388.26 MiB -> 388.26 MiB (-0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@petrochenkov petrochenkov petrochenkov left review comments

Assignees

@petrochenkov petrochenkov

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.93.0

Development

Successfully merging this pull request may close these issues.

5 participants

@yaahc @petrochenkov @bors @rust-timer @rustbot